Skip to content

bugfix: initial audio enabled - #535

Merged
Kimblebee merged 14 commits into
mainfrom
kim/bugfix/initial-audio-enabled
Jul 31, 2026
Merged

bugfix: initial audio enabled#535
Kimblebee merged 14 commits into
mainfrom
kim/bugfix/initial-audio-enabled

Conversation

@Kimblebee

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the audio input toggle component to use Jetpack Compose semantics for state tracking instead of dynamic test tags, updating the corresponding tests and adding helper functions for semantic assertions. Feedback on the changes includes a style guide violation regarding the naming and value of the new AUDIO_INPUT_TOGGLE test tag, as well as redundant click actions on the capture button in the new test cases.

Comment thread app/src/androidTest/java/com/google/jetpackcamera/VideoAudioTest.kt Outdated
Comment thread app/src/androidTest/java/com/google/jetpackcamera/VideoAudioTest.kt Outdated
@Kimblebee
Kimblebee changed the base branch from main to fix/snackbar-assertion July 7, 2026 20:31
@Kimblebee
Kimblebee marked this pull request as ready for review July 8, 2026 17:37
Base automatically changed from fix/snackbar-assertion to main July 9, 2026 18:59
@Kimblebee
Kimblebee enabled auto-merge (squash) July 31, 2026 15:44
@Kimblebee
Kimblebee merged commit 4d8bae0 into main Jul 31, 2026
12 checks passed
@Kimblebee
Kimblebee deleted the kim/bugfix/initial-audio-enabled branch July 31, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants